Skip to content

Conversation

@rohansonecha
Copy link
Collaborator

@rohansonecha rohansonecha commented Oct 14, 2025

The stop operation is not supported on kubernetes. This PR avoids calling stop on a cluster when it is hosted on kubernetes.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@rohansonecha rohansonecha requested a review from cg505 October 14, 2025 22:11
@rohansonecha rohansonecha merged commit a3090e3 into master Oct 14, 2025
22 checks passed
@rohansonecha rohansonecha deleted the no-k8s branch October 14, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants