Proper handling of client provided request prefixes #7730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
commented
Oct 24, 2025
SeungjinYang
commented
Oct 24, 2025
SeungjinYang
force-pushed
the
request-prefix-handling
branch
from
1224839 to
50f2889
Compare
|
/smoke-test |
kevinmingtarja
approved these changes
Oct 25, 2025
SeungjinYang
force-pushed
the
request-prefix-handling
branch
from
2d8cb54 to
04e2740
Compare
SeungjinYang
force-pushed
the
request-prefix-handling
branch
from
04e2740 to
4f0b5d7
Compare
|
/smoke-test -k test_cancel_launch_and_exec_async |
SeungjinYang
force-pushed
the
request-prefix-handling
branch
from
bdcdc7f to
4f0b5d7
Compare
|
/smoke-test -k test_cancel_launch_and_exec_async |
SeungjinYang
force-pushed
the
request-prefix-handling
branch
from
00709ad to
1c598f0
Compare
|
/smoke-test -k test_cancel_launch_and_exec_async |
|
/smoke-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7683
For
sky api logsandsky api cancel, error out if the user supplied request prefix matches multiple requests.For
sky api status, return all requests with prefix if the user supplied request prefix matches multiple requests.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)