Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for launching jobs in parallel using
--num-jobs. Before one command would launch multiple jobs but the actual launching would happen serially, now we use multiple threads on the jobs controller to handle launching.This may not be the right design. A single job launch is handled by scheduling a request and using a long executor normally and a short executor if we're in consolidation mode. What this means is that executor will launch multiple threads to handle this single request which seems to go against our idea of using executors. Another idea would be to spawn multiple requests when we specify
--num-jobsbut we reuse a lot (like the DAG) by launching multiple jobs in the launch function so it would likely take more resources and block other launch requests.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)