Skip to content

Conversation

@DanielZhangQD
Copy link
Collaborator

@DanielZhangQD DanielZhangQD commented Oct 27, 2025

  • Improve log for creating and deleting volumes in k8s
  • Add alias sky volume for sky volumes

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
✗ sky volume apply -y -n pvc1 --type k8s-pvc --size 2GB --infra k8s
Created PVC pvc1-43dbb4ab-481fd3 in namespace default
✗ sky volume delete pvc1
Deleting 1 volume: pvc1. Proceed? [Y/n]:
Deleted PVC pvc1-43dbb4ab-481fd3 in namespace default
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD DanielZhangQD marked this pull request as ready for review October 27, 2025 09:40
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DanielZhangQD DanielZhangQD merged commit c655052 into master Oct 27, 2025
20 checks passed
@DanielZhangQD DanielZhangQD deleted the 3651 branch October 27, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants