Skip to content

Conversation

@kevinmingtarja
Copy link
Collaborator

@kevinmingtarja kevinmingtarja commented Oct 27, 2025

Previously, we were hardcoding the GPU count to be 8/8. But this is only true for the kind clusters in our test infra. This PR fixes it to use a regex pattern for matching, so that it can run on arbitrary k8s clusters with arbitrary amount of GPUs (or no GPUs too).

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@kevinmingtarja
Copy link
Collaborator Author

/smoke-test --kubernetes -k test_kubernetes_show_gpus

@kevinmingtarja
Copy link
Collaborator Author

kevinmingtarja commented Oct 27, 2025

/smoke-test --kubernetes -k test_kubernetes_show_gpus --env-file s3://buildkite-configfile-test/test_gke_config_1.yaml 🟢 now (Failed before this PR)

Copy link
Collaborator

@SeungjinYang SeungjinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinmingtarja for making the test more flexible!

@kevinmingtarja kevinmingtarja merged commit cf381be into master Oct 27, 2025
22 checks passed
@kevinmingtarja kevinmingtarja deleted the fix-test_kubernetes_show_gpus branch October 27, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants