build: perform pdm sync before running commands #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <[email protected]>
Connor1996
changed the title
skyzh
reviewed
Oct 13, 2025
Owner
skyzh
left a comment
skyzh
left a comment
There was a problem hiding this comment.
I wonder if we should ask students to run that before each test in the writeup. It feels like silently sync will make things confusingly slow..?
Collaborator
Author
|
|
Collaborator
Author
|
And there would be info |
wyxpku
pushed a commit
to wyxpku/tiny-llm
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Connor1996 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a build error when running
pdm run build-ext, then I finally found that it's due to oldmlxversion in venv which is not consistent with the version inpdm.lock.Should perform
pdm syncafter updatingpdm.lock, so adding a pre_run hook to run it automatically before running any command.