fix: hide version checks at the end of windows install script #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 62.91% 62.91% -0.01%
==========================================
Files 212 212
Lines 21782 21782
==========================================
- Hits 13705 13704 -1
- Misses 7011 7014 +3
+ Partials 1066 1064 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
zimeg
commented
Aug 29, 2025
scripts/install-windows-dev.ps1
Outdated
| delay 0.3 "Now checking if it's the same Slack CLI..." | ||
| } | ||
| & $SLACK_CLI_NAME _fingerprint | Tee-Object -Variable get_finger_print | Out-Null | ||
| & $SLACK_CLI_NAME --version | Tee-Object -Variable slack_cli_version | Out-Null |
There was a problem hiding this comment.
👁️🗨️ note: Great findings from @ewanek1 hint that this _fingerprint might be causing CI to hang on a first installation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hides the
check_slack_binary_existchecks at the end of the Windows installation script in a debugging attempt of multiple processes in CI 🐛Reviewers
The following commands can be used to test these changes! 🔍
Requirements