Skip to content

ENH: Add Tag Description to Tag Group Dialog #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zdomke merged 4 commits into from
Jan 27, 2026
Merged

ENH: Add Tag Description to Tag Group Dialog #47

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ff8a8d
ENH: Add secondary text to list
zdomke Jan 23, 2026
92d568b
ENH: Truncate description text
zdomke Jan 23, 2026
5ace171
STY: Use divider property rather than component
zdomke Jan 27, 2026
48f2623
STY: Remove unused imports
zdomke Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 49 additions & 33 deletions src/pages/TagPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ import {
DialogContent,
DialogActions,
TextField,
Chip,
ListSubheader,
List,
ListItem,
ListItemText,
ListItemSecondaryAction,
Chip,
} from '@mui/material';
import { Add, Delete, Edit, NoteOutlined } from '@mui/icons-material';
import { TagGroup, Tag } from '../types';
Expand Down Expand Up @@ -328,42 +329,57 @@ export const TagPage: React.FC<TagPageProps> = ({
multiline
rows={2}
/>
<Typography variant="subtitle2" sx={{ mt: 2, mb: 1 }}>
Tags:
</Typography>
</Box>

<Box sx={{ flex: 1, overflowY: 'auto', px: 3, py: 1 }}>
<Box sx={{ flex: 1, overflowY: 'auto', px: 3 }}>
{selectedGroup && selectedGroup.tags.length > 0 ? (
<List dense sx={{ p: 0 }}>
<List sx={{ p: 0 }} subheader={<ListSubheader>Tags</ListSubheader>}>
{selectedGroup.tags.map((tag, idx) => (
<ListItem key={idx}>
<ListItemText primary={tag.name} />
<ListItemSecondaryAction>
{onEditTag && (
<IconButton
edge="end"
aria-label="edit tag"
size="small"
onClick={() => handleOpenTagDialog(tag)}
color="default"
>
{isAdmin ? <Edit fontSize="small" /> : <NoteOutlined fontSize="small" />}
</IconButton>
)}
{isAdmin && onDeleteTag && (
<IconButton
edge="end"
aria-label="delete"
size="small"
onClick={() => handleDeleteTag(tag)}
color="error"
>
<Delete fontSize="small" />
</IconButton>
)}
</ListItemSecondaryAction>
</ListItem>
<>
<ListItem key={idx} divider={idx < selectedGroup.tags.length - 1}>
<ListItemText
primary={tag.name}
secondary={tag.description}
sx={{ pr: 3, overflow: 'hidden' }}
secondaryTypographyProps={{
variant: 'subtitle2',
style: {
whiteSpace: 'nowrap',
overflow: 'hidden',
textOverflow: 'ellipsis',
},
}}
/>
<ListItemSecondaryAction>
{onEditTag && (
<IconButton
edge="end"
aria-label="edit tag"
size="small"
onClick={() => handleOpenTagDialog(tag)}
color="default"
>
{isAdmin ? (
<Edit fontSize="small" />
) : (
<NoteOutlined fontSize="small" />
)}
</IconButton>
)}
{isAdmin && onDeleteTag && (
<IconButton
edge="end"
aria-label="delete"
size="small"
onClick={() => handleDeleteTag(tag)}
color="error"
>
<Delete fontSize="small" />
</IconButton>
)}
</ListItemSecondaryAction>
</ListItem>
</>
))}
</List>
) : (
Expand Down
Loading