Skip to content

Cache geocode intermediate queries to save money! #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
braian87b wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cache geocode intermediate queries to save money! #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df4bd5
Cache geocode intermediate queries to save money!
braian87b May 21, 2019
0d8a30f
Update __init__.py
braian87b May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions googleplaces/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ def _fetch_remote_file(service_url, params=None, use_http_post=False):
return (response.headers.get('content-type'),
fn, response.read(), response.geturl())

locations_cache = {}

def geocode_location(location, sensor=False, api_key=None):
"""Converts a human-readable location to lat-lng.

Expand All @@ -111,17 +113,22 @@ def geocode_location(location, sensor=False, api_key=None):
raises:
GooglePlacesError -- if the geocoder fails to find a location.
"""
params = {'address': location, 'sensor': str(sensor).lower()}
if api_key is not None:
params['key'] = api_key
url, geo_response = _fetch_remote_json(
GooglePlaces.GEOCODE_API_URL, params)
_validate_response(url, geo_response)
if geo_response['status'] == GooglePlaces.RESPONSE_STATUS_ZERO_RESULTS:
error_detail = ('Lat/Lng for location \'%s\' can\'t be determined.' %
location)
raise GooglePlacesError(error_detail)
return geo_response['results'][0]['geometry']['location']
if location in locations_cache:
return locations_cache[location]
else:
params = {'address': location, 'sensor': str(sensor).lower()}
if api_key is not None:
params['key'] = api_key
url, geo_response = _fetch_remote_json(
GooglePlaces.GEOCODE_API_URL, params)
_validate_response(url, geo_response)
if geo_response['status'] == GooglePlaces.RESPONSE_STATUS_ZERO_RESULTS:
error_detail = ('Lat/Lng for location \'%s\' can\'t be determined.' %
location)
raise GooglePlacesError(error_detail)
response = geo_response['results'][0]['geometry']['location']
locations_cache.update({location: response})
return response

def _get_place_details(place_id, api_key, sensor=False,
language=lang.ENGLISH):
Expand Down