Fix smalrubot S1 sensor labels: Unify to sensorPositionsMenu namespace #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespace - Update SENSOR_POSITIONS_MENU to use unified smalrubotS1.sensorPositionsMenu.* IDs - Add port numbers to default values for clarity: - left(A4), right(A5), touch(A2), light(A6), sound(A7) - Improve maintainability by consolidating all sensor labels under single namespace - Separates sensor labels from motor/LED labels for better UX Related to: smalruby/smalruby3-gui#405 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
takaokouji
added a commit
to smalruby/smalruby3-gui
that referenced
this pull request
Sep 13, 2025
- Add sensorPositionsMenu namespace translations with port numbers: - 左(A4), 右(A5), タッチ(A2), 光(A6), 音(A7) - Simplify positionsMenu for motors/LEDs to just '左', '右' - Improves hardware port visibility and user experience - Supports unified sensor label namespace from scratch-vm Related to: #405 Companion to: smalruby/scratch-vm#37 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
センサーラベルを統一した名前空間に移行し、保守性を向上させます。
Unify sensor labels to a consistent namespace to improve maintainability.
Changes Made
sensor labels namespace unification
smalrubotS1.sensorPositionsMenu.*namespace:smalrubotS1.sensorPositionsMenu.left(A4)smalrubotS1.sensorPositionsMenu.right(A5)smalrubotS1.sensorPositionsMenu.touch(A2)smalrubotS1.sensorPositionsMenu.light(A6)smalrubotS1.sensorPositionsMenu.sound(A7)Default values enhanced
Code organization
Technical Details
File Changed:
src/extensions/scratch3_smalrubot_s1/index.js: UpdatedSENSOR_POSITIONS_MENUmessage IDsImpact:
Testing
Related
🤖 Generated with Claude Code