Skip to content

Conversation

@rcoh
Copy link
Collaborator

@rcoh rcoh commented Dec 2, 2025

Motivation and Context

#4429

Description

Event stream operations with initial-request messages send that message unsigned, whose root cause is described in the issue above.

To resolve it, instead of pre-serializing the initial message to bytes, this PR

  1. creates a wrapper marshaller that can handle both regular events and initial messages
  2. creates a stream out of the initial message
  3. chains that stream with the event stream
  4. lets the entire combined stream flow through MessageStreamAdapter for signing

Testing

Added client codegen test for signing initial message and event.

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 marked this pull request as ready for review December 4, 2025 22:48
@ysaito1001 ysaito1001 requested review from a team as code owners December 4, 2025 22:48
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

A new generated diff is ready to view.

A new doc preview is ready to view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants