Skip to content

Make transformers not throw an error when receiving an empty resutls file #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
northdpole wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Make transformers not throw an error when receiving an empty resutls file #1068

northdpole wants to merge 33 commits into from

Conversation

@northdpole
Copy link
Contributor

@northdpole northdpole commented Aug 19, 2025

No description provided.

@northdpole northdpole marked this pull request as draft August 19, 2025 23:20
@northdpole northdpole force-pushed the make-scanners-not-exit-on-0-findings branch from 94c9fc4 to 4b12f17 Compare August 20, 2025 07:27
@northdpole northdpole marked this pull request as ready for review August 20, 2025 07:36
ptzianos
ptzianos reviewed Aug 27, 2025
View reviewed changes
components/scanners/zaproxy/internal/transformer/transformer_test.go
ctx := context.WithValue(ctx, component.SCANNER_TARGET_METADATA_CTX_KEY, &ocsffindinginfo.DataSource{
TargetType: ocsffindinginfo.DataSource_TARGET_TYPE_WEBSITE,
})
ctx, cancel := context.WithCancel(ctx)
Copy link
Contributor

@ptzianos ptzianos Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this context should have a timeout, same goes for other contexts used in these tests

@ptzianos
Copy link
Contributor

ptzianos commented Aug 27, 2025

@northdpole how do we test that these components will produce an empty results file if they run and they don't discover anything? or we sure that it's the binaries' behaviour? can we document that somewhere?

@northdpole northdpole force-pushed the make-scanners-not-exit-on-0-findings branch 3 times, most recently from 859e15a to bac1f27 Compare August 28, 2025 17:57
@northdpole
Copy link
Contributor Author

northdpole commented Aug 28, 2025 •
edited
Loading

@northdpole how do we test that these components will produce an empty results file if they run and they don't discover anything? or we sure that it's the binaries' behaviour? can we document that somewhere?

  • bandit: creates valid json with empty findings
  • checkov: creates valid sarif with empty findings
  • codeql: does not create files -- no files is handled
  • credo: valid sarif, empty findings
  • kics: valid sarif, empty findings
  • mobsfscan: valid sarif, empty findings
    - nancy: if it's not a go project component fails
  • osv-scanner: empty json file
  • semgrep: valid sarif file
  • sobelow: empty json file
  • trivy: valid sairf, empty results
  • trufflehog: its own json, seems valid

@northdpole northdpole force-pushed the make-scanners-not-exit-on-0-findings branch 2 times, most recently from 305a652 to f2d8429 Compare August 28, 2025 20:15
@northdpole northdpole force-pushed the make-scanners-not-exit-on-0-findings branch 2 times, most recently from aa341e3 to 1f6c82b Compare August 28, 2025 23:09
@northdpole northdpole force-pushed the make-scanners-not-exit-on-0-findings branch from 1f6c82b to 7230277 Compare August 29, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptzianos ptzianos ptzianos left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@northdpole @ptzianos