Skip to content

Update to PHP7 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sn3p wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to PHP7 #9

sn3p wants to merge 3 commits into from

Conversation

@sn3p
Copy link
Owner

@sn3p sn3p commented Jan 14, 2018 •
edited
Loading

Closes #8

  • mysql to mysqli
  • ereg_match to preg_match
  • Fix passing too few function arguments errors
  • Test imports
  • Test ftp log download

Think this is done, just need some testing. Help with this is more than welcome!

@sn3p sn3p force-pushed the update-to-mysqli branch from 57b5520 to c7396f3 Compare January 14, 2018 19:34
@sn3p sn3p changed the title Update to mysqli Update to PHP7 Jan 15, 2018
@sn3p sn3p force-pushed the update-to-mysqli branch from 9362f39 to 4450da3 Compare January 16, 2018 00:19
@sn3p sn3p added the wip label Jan 16, 2018
@sn3p sn3p added ready and removed wip labels Feb 4, 2018
@sn3p sn3p mentioned this pull request Feb 22, 2018
Open
@sn3p
Copy link
Owner Author

sn3p commented Feb 25, 2018

Something seems to be off. As soon as I upgrade, I see all my recent matches but when I open one, it only shows the MATCH STATS block. All the others are gone.

This was also the case before the upgrade when I used PHP versions > 5.4

Mhm weird, does this happen for all matches? You probably having suppressed errors, could you turn on error_reporting in functions.php and try again?

Thanks for testing!

@ThomasVdBerge
Copy link

ThomasVdBerge commented Feb 26, 2018

i'm guessing it is conflicting with setting PHP to strict on the following error lines:

Warning: gzdecode(): data error in /var/www/html/pages/match_info_charts.php on line 38

Warning: gzdecode(): data error in /var/www/html/pages/match_info_charts.php on line 38

Warning: gzdecode(): data error in /var/www/html/pages/match_info_charts.php on line 38

Warning: gzdecode(): data error in /var/www/html/pages/match_info_charts.php on line 38

@sn3p
Copy link
Owner Author

sn3p commented Feb 26, 2018 •
edited
Loading

So it has to do with the charts and decoding gzipped data.
Looks very similar to the issues fixed in #13 and this post on StackOverflow.

@randommonk your thought on this matter?

@sn3p
Copy link
Owner Author

sn3p commented Mar 4, 2018

@ThomasVdBerge just curious, is the problem related to this PR or are you getting the same errors with current master?

@ThomasVdBerge
Copy link

ThomasVdBerge commented Mar 5, 2018

Not related to this PR, I have the same errors with current master on PHP7

@sn3p sn3p requested a review from randommonk September 1, 2018 09:47
@davidbernard04 davidbernard04 mentioned this pull request Feb 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randommonk randommonk Awaiting requested review from randommonk

Assignees

No one assigned

Labels

ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sn3p @ThomasVdBerge