Skip to content

don't exit if no namespace #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't exit if no namespace #20

wants to merge 1 commit into from

Conversation

@ableeb
Copy link

@ableeb ableeb commented Apr 10, 2020

kubernetes was not showing in segments if no namespace. This PR removes duplicate namespace value from the first try block in __call__ method.

@andrewdmcleod
Copy link

andrewdmcleod commented Jan 6, 2022

this PR is pretty useful - it solves my own problem and others in the issues

@ableeb
Copy link
Author

ableeb commented Jan 29, 2024

anyone with write access care to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akguptay2k akguptay2k akguptay2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ableeb @andrewdmcleod @akguptay2k