Skip to content

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 22, 2025

In 3instruments_collis, we can notice a slight bump at the beginning of the deployment of the catheter.
One of the reason is that the first liberated point (when the deployed length increases and need to "free" one DOF) when freed, first go its restPosition. And in this scene, the restPosition is set by the RegularGrid (and is a linear set line of points)

So to fix this, while "fixing" the undeployed tool, the restPosition is also set at startPosition.

EDIT: actually this PR is much more important than only fixing the "bump".
Now, the starting orientation of the beam is solely set by the startingPos data, and no more from the orientation (?) of the grid which was weird.

Illustration of the bump:
Before
bumping_deploy

After
fixed_deploy

And illustration of the shenanigans of the bug in the state position: (this is supposed to go along the Z axis)
Before
Screenshot 2025-10-13 at 11 10 58

After
Screenshot 2025-10-13 at 11 09 38

@fredroy fredroy added pr: fix pr: status to review To notify reviewers to review this pull-request labels Sep 22, 2025
@bakpaul
Copy link
Contributor

bakpaul commented Sep 23, 2025

Doesn't this affect the internal forces of the beam ? The deformed state being compared to a wrong rest state ?

@fredroy fredroy changed the title [IRC] Reset the restPositions while fixed [IRC] Reset the restPositions while fixed - make consistent StartPosition Oct 13, 2025
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 16, 2025
@hugtalbot
Copy link
Contributor

hugtalbot commented Oct 16, 2025

Checking the regression raised the fact that the error on DoFs was significant. This has beem fixed along with a deeper bug on the definition of the initial orientation. Data startPoint is only used for the position, the orientation is given by the topology used. Now only the startPoint data matters and the PR is more breaking.

@epernod epernod merged commit d42981c into sofa-framework:master Oct 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants