Hide non-public interface #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h is using imgui.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to tackle #152 with option 2 : encapsulate
imguicode as much as possible and limit installed headers to unvendored ones.Aim is to make SofaGLFW compatible with conda-forge requirements for making its package.
As SimpleIni is in public headers, it must be added as a dependency and can be find or fetched as others. A PR for
SimpleInihas been submitted to make it also available on conda-forge ( conda-forge/staged-recipes#31757 ).Concerning
imgui, it is not exposed anymore in public headers. But extensions might need it, so they will have to fetch it as done in SofaImGui. A typical example isSofaImGui.Cameraextension (still WIP).