[fork] Fix type forward declaration in the bindings #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nows about them. The problem: Depending on the definition order of the binded classes, there may have incorrect types if Base is useing BaseData... but BaseData is only binded after Base. The PR propose a solution for that using a decidcated "forward" registration patter.
…-how-to-fix-definition
…definition' into pr-typehint-example-how-to-fix-definition
It should be completed if ones want more feature than just class declaration
…-how-to-fix-definition
…-how-to-fix-definition
hugtalbot
added
pr: status to review
pr: clean-fix
pr: fast-merge
pr: backport todo
dependencies
hugtalbot
changed the title
Contributor
|
Ok I see. |
bakpaul
pushed a commit
that referenced
this pull request
Jan 9, 2025
* Example on how to fix pybind11 type forward declaration so stubgens knows about them. The problem: Depending on the definition order of the binded classes, there may have incorrect types if Base is useing BaseData... but BaseData is only binded after Base. The PR propose a solution for that using a decidcated "forward" registration patter. * Add binding for BaseClass It should be completed if ones want more feature than just class declaration * Generalize the pybind11 forward declaration of classes. --------- Co-authored-by: Damien Marchal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fork of #457 authored by @damienmarchal
We urgently needed to merge it while fixing the conflicts on a branch which was protected.
Closes #457