Skip to content

[Sofa.Simulation.Graph] Remove DAGSimulation and DAGNode #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damienmarchal wants to merge 43 commits into
base: master
Choose a base branch
from
Open

[Sofa.Simulation.Graph] Remove DAGSimulation and DAGNode #5610

damienmarchal wants to merge 43 commits into from

Conversation

@damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Jul 14, 2025 •
edited
Loading

Follow up discussions in this issue: #5556
The PR is based on: #5566

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Jul 14, 2025
@damienmarchal
Move Simulation's singleton initialization from graph/init.cpp to Sim…
9ba0c0b 
…ulation.cpp

Not perfect but much better.
Next step is to remove the singleton.
@damienmarchal damienmarchal mentioned this pull request Jul 14, 2025
Open
@damienmarchal damienmarchal mentioned this pull request Jul 14, 2025
Merged
@bakpaul
Copy link
Contributor

bakpaul commented Jul 16, 2025

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Jul 16, 2025

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@damienmarchal damienmarchal added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Jul 16, 2025
@hugtalbot hugtalbot added the refactoring Refactor code label Jul 16, 2025
@damienmarchal
Clean of the integration of DAGNode into Node
00acc17 
Important things are:
- integration of NODEgetMeshTopologyLink into getMeshTopologyLink

- refactoring of updateContext, updateVisualContext and updateSimulationContext
Some code was shared between them.. so I factorize that into a new method called initializeContexts()

non important things are removal of un-needed static_cast<Node*>
@damienmarchal
Add deprecation macro in DAGNode.h forwarding to Node
0742e65
@damienmarchal
Merge branch 'master' into xp-merge-dagnode-node
fc2ede0
@damienmarchal
Merge branch 'master' into xp-merge-dagnode-node
4fe2197
@damienmarchal
Merge branch 'master' into xp-merge-dagnode-node
35d6b2b
@damienmarchal
Merge branch 'master' into xp-merge-dagnode-node
14be651
@damienmarchal
Remove DAGNode and DAGSimulation
ebd355b
@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Oct 17, 2025
@damienmarchal
Copy link
Contributor Author

damienmarchal commented Oct 17, 2025 •
edited
Loading

Window link should be fixed... hope there is no other (I wonder how many compilation time was lost just because of the link error on windows :))

EDIT: @bakpaul, @hugtalbot, @fredroy, maybe the suggestion from chatgpt would help on having the non windows developpers to detect the error before the CI and without forcing them to have two OS just for testing this corner case: https://chatgpt.com/share/68f1f014-2c00-8002-bc41-9c2498b3ba6a

@sofabot
Copy link
Collaborator

sofabot commented Oct 17, 2025

[ci-depends-on] detected during build #19.

All dependencies are merged/closed. Congrats! 👍

@bakpaul
Copy link
Contributor

bakpaul commented Oct 22, 2025

There are still some tests failing

@sofabot
Copy link
Collaborator

sofabot commented Oct 23, 2025

[ci-depends-on] detected during build #20.

All dependencies are merged/closed. Congrats! 👍

@damienmarchal damienmarchal added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 30, 2025
@sofabot
Copy link
Collaborator

sofabot commented Oct 30, 2025

[ci-depends-on] detected during build #21.

All dependencies are merged/closed. Congrats! 👍

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 30, 2025
@sofabot
Copy link
Collaborator

sofabot commented Oct 30, 2025

[ci-depends-on] detected during build #22.

All dependencies are merged/closed. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented Nov 6, 2025

[ci-depends-on] detected during build #23.

All dependencies are merged/closed. Congrats! 👍

@hugtalbot
Copy link
Contributor

hugtalbot commented Nov 13, 2025

The CI shows tests failing: https://www.sofa-framework.org/dash/?branch=origin/PR-5610 @damienmarchal

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 13, 2025
@damienmarchal
[Sofa.Core] Add a castTo in fwd.h to support "const" conversion
eca4767
@damienmarchal
[Sofa.Core] Add a getPathName() method in BaseData
6782a19 
There was no method to get the PathName() to a BaseData only a linkpath (so with the
"@" prefix indicating a link).
I add the missing feature and make some minor cleaning
@damienmarchal
Merge remote-tracking branch 'upstream/master' into xp-remove-dagsimu…
3bc1c5d 
…lation

# Conflicts:
#	Sofa/framework/Core/src/sofa/core/objectmodel/BaseData.cpp
#	Sofa/framework/Core/src/sofa/core/objectmodel/BaseObject.cpp
@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 27, 2025
@sofabot
Copy link
Collaborator

sofabot commented Nov 27, 2025

[ci-depends-on] detected during build #24.

All dependencies are merged/closed. Congrats! 👍

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Dec 4, 2025
@hugtalbot
Copy link
Contributor

hugtalbot commented Dec 4, 2025

CI is failing, to test the PR do not hesitate to use the "ci-build" keyword ;)

@hugtalbot hugtalbot added this to the v26.06 milestone Dec 4, 2025
@damienmarchal
Copy link
Contributor Author

damienmarchal commented Dec 4, 2025

@hugtalbot Are you sure that [ci-build] works with pr-wip, ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: status wip Development in the pull-request is still in progress refactoring Refactor code

Projects

None yet

Milestone

v26.06

Development

Successfully merging this pull request may close these issues.

4 participants

@damienmarchal @bakpaul @sofabot @hugtalbot