-
Notifications
You must be signed in to change notification settings - Fork 341
[Helper] Add Taskflow dependency to CMake build system #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Integrate Taskflow as a header-only library, update CMake configuration to locate and fetch Taskflow if necessary, and include relevant headers.
|
It remind me so much something we did with PJBensoussan around 2006 in SOFA. |
|
[ci-build][with-all-tests][force-full-build] |
|
Modern cmake usage is more a suggestion here (my commits 05691e0 and cec0c7a ). Both solutions work fine and looks good to me. It was mainly driven by the idea of being consistent with cmake config files provided by the Taskflow library itself. |
|
About cec0c7a, it is was a conclusion in the last dev meeting. So, thank you for having done the job! Another question: is there something to do regarding the package/installation process? |
|
The only thing I think is still missing here is the find package for the generated cmake config file of Sofa.Helper, i.e. adding in the Sofa.HelperConfig.cmake.in :
|
ac716e1 to
08eece9
Compare
|
[ci-build][with-all-tests] |
f844776 to
7bba77a
Compare
|
[ci-build][with-all-tests] |
|
[ci-build][with-all-tests][force-full-build] |
|
Just for information, there would/will be some extra steps necessary after looking for the Taskflow package in the Sofa.Helper CMakeLists.txt to install the library (headers + cmake config files) in the case of building the binary package on Windows. But this when we'll have migrated our Windows support on Pixi and it's purely related to it, so I'll do it in #5252. |
Integrate Taskflow as a header-only library, update CMake configuration to locate and fetch Taskflow if necessary, and include relevant headers.
taskflow: https://github.com/taskflow/taskflow
More information:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if