-
Notifications
You must be signed in to change notification settings - Fork 341
[Core] Start renaming BaseObject to BaseComponent #5794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
PR accepted |
|
The CI says otherwise... |
|
Agreed during the dev meeting |
|
A lot of For example, the following code used to compile: template<class T>
class DummyComponent : public BaseObject
{
public:
SOFA_CLASS(DummyComponent<T>, BaseObject);
};but the following is working with the compatibility: template<class T>
class DummyComponent : public core::objectmodel::BaseObject
{
public:
SOFA_CLASS(DummyComponent<T>, core::objectmodel::BaseObject);
}; |
cf648dc to
4cf5635
Compare
A not-working PR to start the discussion on renaming BaseObject to BaseComponent. It makes more sense for me as we name the classes in the factory 'Component'.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if