Skip to content

[FileSystem] Add openFileWithDefaultApplication method #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EulalieCoevoet wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FileSystem] Add openFileWithDefaultApplication method #5798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4be277
[FileSystem] adds openFileWithDefaultApplication method
EulalieCoevoet Nov 27, 2025
eba758f
cleaning
EulalieCoevoet Nov 28, 2025
368c952
Fixes open file for Windows
HanaeRateau Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions Sofa/framework/Helper/src/sofa/helper/system/FileSystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
# include <winerror.h>
# include <strsafe.h>
# include "Shlwapi.h" // for PathFileExists()
#include <shellapi.h>
#else
# include <dirent.h>
# include <sys/stat.h>
Expand Down Expand Up @@ -497,6 +498,34 @@ std::string FileSystem::append(const std::string_view& existingPath, const std::
return std::string(existingPath) + "/" + std::string(toAppend);
}

bool FileSystem::openFileWithDefaultApplication(const std::string& filename)
{
bool success = false;

if (!filename.empty())
{
if (!FileSystem::exists(filename))
{
msg_error("FileSystem::openFileWithDefaultApplication()") << "File does not exist: " << filename;
return success;
}

#ifdef WIN32
if ((INT_PTR)ShellExecuteA(nullptr, "open", filename.c_str(), nullptr, nullptr, SW_SHOWNORMAL) > 32)
success = true;
#elif defined(__APPLE__)
const std::string command = "open \"" + filename + "\"";
if (std::system(command.c_str()) == 0)
Copy link
Contributor

@fredroy fredroy Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::system() is not safe ; as a user could call this function with an input crafted to do malicious things...
So the solution would be to sanitize the inputs or the best solution is to use fork() and execvp() (for linux at least.)

Copy link
Contributor Author

@EulalieCoevoet EulalieCoevoet Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sorry I didn't know it was bad practice to use std::system. I'll make the changes for both macOS and linux.

success = true;
#else
const std::string command = "xdg-open \"" + filename + "\"";
if (std::system(command.c_str()) == 0)
success = true;
#endif
}

return success;
}

} // namespace system
} // namespace helper
Expand Down
3 changes: 3 additions & 0 deletions Sofa/framework/Helper/src/sofa/helper/system/FileSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ static std::string append(const std::string_view& existingPath, const std::strin
return append(append(existingPath, toAppend), args...);
}

/// Open a file with the default application associated to its type by the OS
static bool openFileWithDefaultApplication(const std::string& filename);

};


Expand Down
Loading