Skip to content

Conversation

@remibessard
Copy link
Contributor

(allow node names with / , e.g. '/universe/base')

Motivation was to import OpenSim simulation in SOFA, where articulated chain architecture in the scene is described by frames with names such as "/universe/base".
This will be replicated in the SOFA scene using Sofa.RigidBodyDynamics plugin, while trying to stay as close as possible to OpenSim's description for the sake of future comparisons.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal
Copy link
Contributor

Hello @remibessard

I'm curious about this change.
I wonder if:

  • it wouldn't it be better and clear to map the frames hierarchies from OpenSim to our classical Node/Component structure
  • or alternatively if an adaptation layer converting "/" to another symbol wouldn't be an safer option
  • finally, if the two first are not desirable, if it wouldn't be preferable to use \ to protect from both "spaces" and "/" from parser interpretation... having quotation mark in the middle of the string looks weird to me.

@remibessard
Copy link
Contributor Author

Thanks for your feedback @damienmarchal .

I would go for the 2. as regarding 1. I prefer to keep SOFA simulations's hierarchies closer to Sofa.RigidBodyDynamics structure compared to OpenSim's hierarchies (pinocchio/SOFA mappings implied in such simulations).

@fredroy fredroy added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Dec 11, 2025
@hugtalbot hugtalbot added this to the v26.06 milestone Dec 12, 2025
@hugtalbot
Copy link
Contributor

OK so we agree on option 2: convert "/" to another symbol (like e.g. "|")

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status wip Development in the pull-request is still in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants