Fix PR polling to handle branch deletion after merge #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PR is merged, GitHub deletes the branch automatically. This caused 'gh pr view <branch-name>' to fail with "no pull requests found", breaking the --yes flag's automated polling feature. Changes: - Capture PR number when creating the PR via 'gh pr create' - Use PR number as fallback when branch-based lookup fails - Add _extract_pr_number helper to parse PR URL from gh output - Update wait_for_pr_merge to accept branch_name and pr_number params The fix ensures polling continues to work even after the PR branch is deleted, by falling back to 'gh pr view <number>' which always works. Includes comprehensive test coverage for the polling mechanism. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
villelaitila
force-pushed
the
fix-pr-polling-branch-deleted
branch
from
b5b040a to
82adcca
Compare
Looking good 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gh pr create_extract_pr_numberhelper to parse PR URL from gh outputProblem
When using
--yesflag, the automated polling mechanism usedgh pr view <branch-name>to check PR status. However, when a PR is merged, GitHub automatically deletes the source branch, causing the command to fail with "no pull requests found".Solution
Now the script:
gh pr createoutput URLTest plan
pytest tests/test_release_automation.py -v🤖 Generated with Claude Code