Skip to content

Conversation

@BlitzKraft
Copy link

@BlitzKraft BlitzKraft commented Jul 16, 2025

This currently assumes config.yaml and directory media are present in the root directory of the development app and are correct.

Requires a new dev-only dependency JSDOM to use and modify the HTML DOM of the mock-appstore template. Attached are screenshots with the example config for "Cute Kittens".

CuteKittensMockUp

I created a generic and minimal app-store-like page, which is also included in the pull-request here.

Edit: The ratings/reviews are only for appearance, and are hard-coded in the html template.

Copy link

@Michaelsulistio Michaelsulistio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Here's some feedback:

  1. Remove JSDOM dependency

If possible, I'd like a dependency free solution. I think this can be done by in-lining the HMTL and using JS Template Literals to fill in the content.

Let me know what you think here.

  1. Visual Styling

The preview differs too greatly from the actual dApp Store Listing Page. It's important to get the main details right like sizing, placement, and layout.

@ankur2136 ankur2136 self-requested a review July 17, 2025 22:02
Copy link
Contributor

@ankur2136 ankur2136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests.

@BlitzKraft
Copy link
Author

Working on implementing the changes, as well as tests. I will push an update as soon as I can. Tentatively by tomorrow.

@BlitzKraft
Copy link
Author

Addressed visual styling. Working on removing the JSDOM dependency and adding tests.
UpdateUI

@BlitzKraft
Copy link
Author

I understand that I need to remove the JSDOM dependency. However, the alternative is string manipulation which leaves too many edge cases to handle. I am thinking having a DOM parser is more sane here. Happy to switch to another one, but the original feedback was to remove the external dependency entirely.

I will continue to work on tests for now, while also looking for other solutions for removing an external dependency. Please let me know if you have any further insight. Especially since the only choices I see are DOM manipulation or string manipulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants