Add notify:filter feature #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it really useful as defined in this PR?
I think we need to be more specific. If we want to allow matching based on any triple pattern we can most likely specify that right away. |
|
Sure, let's have rough consensus in #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter feature to refine the characteristics of notifications (towards resolving #159 ).
I suggest that we work on modeling the core filter object (in subsequent PRs), e.g.,
typeis a good candidate to filter activity types, and possiblyactor.. so perhaps the object can be close to an AS2 Object (including Activity), but it should be possible to extend further e.g., Add activities of Annotation objects with a particular license. Makes sense? We can continue in 159.