[Admin][Settings] Introduce zone creation and modification capability #6224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6224 +/- ##
==========================================
+ Coverage 88.82% 88.86% +0.04%
==========================================
Files 851 857 +6
Lines 18348 18415 +67
==========================================
+ Hits 16298 16365 +67
Misses 2050 2050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If you used Canada in the video in an effort to get me to pay attention to this video, it worked. 🙂 |
chaimann
force-pushed
the
admin-zones-add-edit
branch
2 times, most recently
from
987a16e to
a443fca
Compare
tvdeyen
force-pushed
the
admin-zones-add-edit
branch
from
a443fca to
603ca9b
Compare
|
@chaimann do you mind to run |
github-actions
bot
added
changelog:solidus_api
chaimann
force-pushed
the
admin-zones-add-edit
branch
from
32c4493 to
5b39007
Compare
Extend `AllowedNames` to include `on`.
To avoid lag when rendering states options for zone form, use "src" attribute that will point "solidus-select" to the resource that contains all states. Installed: - blueprinter - for object serialization; Introduced: - state_blueprint - simple serializer with a "state_with_country" view for zones states select; - states_controller - resource with states; - states_with_country now caches the result, as states/countries are not going to be updated regularly, so we can save on preloading countries on each request, allowing the values to be cached over time; - resources_controller#index - added ability to respond to json format
No need to pass `value` argument to forms/field component, as value is being calculated when calling `#select`.
Shorter way to get the value from object
There's some bug with Rubocop that even though `on` is specified as allowed parameter name, rubocop still complains
TIL yaml treats true, on and yes as boolean values. So there was no Rubocop bug, but rather `on` was not treated as a string literal.
tvdeyen
force-pushed
the
admin-zones-add-edit
branch
from
5b39007 to
9b7e333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6155
Introduces new UI for zones creation and modification.
Other new stuff:
Showcase
Screen.Recording.2025-04-30.at.13.05.21.mov
Checklist