Moving args to querystring #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation behind this change? |
|
This allows the ability to dynamically adjust the arguments. In my case, i am proxying gotty and the websockets using AspNetProxy. I have a requirement to dynamically change the resulting command that is ultimately being called at the point of the proxy. When the command argument is encapsulated in the InitMessage, it’s not possible to change the content of the initmessage, but i could when it was made available in the query string. |
|
I personally prefer the commands not being readily available in e.g. proxy logs, but I'm sympathetic to your use case. Can you make it optional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than passing the arguments in the json payload, the arguments are instead included in the query string.