Mark run function as unsafe #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extreme/src/lib.rs
Lines 24 to 44 in 74e2505
Hi, the unsafe function(new_unchecked) called needs to ensure that the parameter must be:
https://doc.rust-lang.org/std/pin/struct.Pin.html#method.new_unchecked
and the developer who calls the run function may not notice this safety requirement.
Marking them unsafe also means that callers must make sure they know what they're doing.