F2dace/fix parameter array #2214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
_const_eval_basic_typetransformation in the Fortran parser to propagate elements fromglobal constant
PARAMETERarrays throughout the AST.Given that the parameter array does not change and the declaration and definition are available in the same AST node, the transformation can handle array index offsets. The transformation also performs bounds checks to assert that referenced indices are valid.
Additionally, we avoid discarding
PARAMETERarrays inconsolidate_global_data_into_arg, given that variable array referencespar_arr(var)cannot be resolved. Our fix ensures that the array definition remains in the AST/SDFG for later use and does not get pruned prematurely.