Implement label context lines for diagnostics rendering #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriksvensson
requested changes
Nov 12, 2025
Contributor
patriksvensson
left a comment
patriksvensson
left a comment
There was a problem hiding this comment.
Nothing to complain about in this PR, but left a minor thing I want to discuss before merging.
- Adds lines around the labels with [DIM] - Either Report or Label level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a view like this
You can either specify a context length at the report level or individually for each Labels. Wasn't sure if Label was the right spot, but they had the Location so that's where I ended up on. Added some code to compress down consecutive lines too to facilitate. Happy to tweak, of course!
would close #13