Use spin.alt domain for service chaining#2736
Use spin.alt domain for service chaining#2736itowlson wants to merge 1 commit intospinframework:mainfrom
spin.alt domain for service chaining#2736Conversation
crates/locked-app/src/locked.rs
Outdated
|
|
||
| /// If present and required in `host_requirements`, the host must support | ||
| /// local service chaining (*.spin.internal) or reject the app. | ||
| /// local service chaining (*.spin.alt/.internal) or reject the app. |
There was a problem hiding this comment.
nit: Only reading the doc comment it's somewhat unclear whether both are supported.
There was a problem hiding this comment.
Ugh, that also makes me think that this becomes another compatibility flag because an app that uses spin.alt won't work in an environment that supports only spin.internal.
There was a problem hiding this comment.
Given that we're doing this with a major release I think it should be fine to just note in the docs that/how it changed for 3.0.
There was a problem hiding this comment.
That rather flies in the face of being able to validate that an application runs in other environments though, which was the whole point of adding the host requirements to the lockfile in the first place.
There was a problem hiding this comment.
I suppose the principled thing would be to add a e.g. local_service_chaining_alt host requirement.
|
Just going to note that we'll want to bring this change into the Factors work as well. We're close to merging that into main which will get rid of the possibility of things landing in main but not in factors. |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
service-chaining-use-alt-tld
branch
from
5884cfc to
fe31cfa
Compare
5 participants
Fixes #2731