Conversation
Collaborator
|
@lann I think you would likely be the most relevant reviewer for this |
lann
reviewed
Nov 18, 2025
Collaborator
There was a problem hiding this comment.
This was mostly just a shallow pass here with a few surface-level comments.
Looking at how this code is working, I think there may be a viable approach that wouldn't require changes to the outbound factors. I only have a minute right now but briefly:
- Use a task-local to manage state through the host-guest-host burger
- Use an otel span processor that uses that task-local to conditionally reparent spans
rylev
reviewed
Nov 24, 2025
Collaborator
|
@lann do you mind taking another pass at this? |
lann
reviewed
Jan 15, 2026
Collaborator
lann
left a comment
There was a problem hiding this comment.
This review might take a while - leaving an initial batch of comments now but I'll have to come back to it.
lann
reviewed
Feb 4, 2026
itowlson
reviewed
Feb 4, 2026
itowlson
reviewed
Feb 5, 2026
2ab89f1 to
f387a2b
Compare
0530a44 to
8409053
Compare
Adds experimental support for WASI OTel Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com> Co-authored-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
8409053 to
07e9742
Compare
fibonacci1729
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is an implementation of WASI OTel which gives guest applications the ability to export traces, metrics and logs with OpenTelemetry SDKs.
We see two options for adding this to Spin:
To help ease adoption, we would prefer to pass a flag to spin up, but we know there was some previous work around this with wasip3 so we're happy to defer to that process.
Some additional notes:
Cargo.toml, you will notice that certain experimental features are being enabled for theopentelemetry-sdkdependency, and that we are usingreqwest-clientinstead ofreqwest-blocking-clientin theopentelemetrydependency. These are all to prevent runtime errors that come from the default OpenTelemetry dependency configurations conflicting with Spin's async runtime.wasi-otelhas been moved to Phase 1.Usage
To try the features added in this PR, do the following: