[MOD/#408] ci 분리 #409
[MOD/#408] ci 분리 #409
Conversation
Hyobeen-Park
requested review from
Roel4990,
angryPodo and
chattymin
and removed request for
a team
WalkthroughPR 분기에서 실행되는 CI를 분리함. 새 ktlint 전용 워크플로우를 추가하고, 기존 PR 빌더 워크플로우에서 린트 단계를 제거해 빌드 전용으로 조정함. JDK 18, Gradle 캐시 설정, local.properties 생성 및 시크릿 주입, ktlintCheck와 빌드 실행 구성을 포함함. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub
participant Lint as ktlint_checker.yml
participant Build as pr_builder.yml
Dev->>GH: Open/Update PR (to develop/main)
GH-->>Lint: Trigger workflow
GH-->>Build: Trigger workflow
rect rgba(200,230,255,0.3)
note over Lint: ktLint Checker
Lint->>Lint: Checkout + Gradle cache
Lint->>Lint: Setup JDK 18
Lint->>Lint: chmod + generate local.properties<br/>inject secrets
Lint->>Lint: Run ./gradlew ktlintCheck -PcompileSdkVersion=35
end
rect rgba(200,255,200,0.3)
note over Build: PR Builder
Build->>Build: Checkout + (existing steps)
Build->>Build: Build with Gradle
end
Lint-->>GH: ktlint status
Build-->>GH: build status
GH-->>Dev: Report checks (separate lint/build)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🪛 actionlint (1.7.7).github/workflows/ktlint_checker.yml17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) 20-20: the runner of "actions/cache@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) 30-30: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ktlint_checker.yml(1 hunks).github/workflows/pr_checker.yml(0 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/pr_checker.yml
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/ktlint_checker.yml
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
20-20: the runner of "actions/cache@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
30-30: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ktLint Checker
- GitHub Check: PR Checker
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Gradle cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.gradle/caches | ||
| ~/.gradle/wrapper | ||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-gradle- | ||
|
|
||
| - name: set up JDK 18 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: 18 | ||
| distribution: 'temurin' |
There was a problem hiding this comment.
GitHub 기본 액션 버전을 v4 이상으로 올려야 합니다.
Line 17, Line 20, Line 30에서 actions/checkout@v3, actions/cache@v3, actions/setup-java@v3를 그대로 사용하면 현재 GitHub Actions 런너(Node 20)에서 곧바로 실패합니다. 각 액션의 v4 릴리스는 Node 20을 지원하므로 반드시 올려 주세요. 기존 pr_checker 흐름도 같은 제약을 받으니 함께 정비하는 편이 안전합니다.
- - name: Checkout
- uses: actions/checkout@v3
+ - name: Checkout
+ uses: actions/checkout@v4
...
- - name: Gradle cache
- uses: actions/cache@v3
+ - name: Gradle cache
+ uses: actions/cache@v4
...
- - name: set up JDK 18
- uses: actions/setup-java@v3
+ - name: set up JDK 18
+ uses: actions/setup-java@v4📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: actions/checkout@v3 | |
| - name: Gradle cache | |
| uses: actions/cache@v3 | |
| with: | |
| path: | | |
| ~/.gradle/caches | |
| ~/.gradle/wrapper | |
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }} | |
| restore-keys: | | |
| ${{ runner.os }}-gradle- | |
| - name: set up JDK 18 | |
| uses: actions/setup-java@v3 | |
| with: | |
| java-version: 18 | |
| distribution: 'temurin' | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Gradle cache | |
| uses: actions/cache@v4 | |
| with: | |
| path: | | |
| ~/.gradle/caches | |
| ~/.gradle/wrapper | |
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }} | |
| restore-keys: | | |
| ${{ runner.os }}-gradle- | |
| - name: set up JDK 18 | |
| uses: actions/setup-java@v4 | |
| with: | |
| java-version: 18 | |
| distribution: 'temurin' |
🧰 Tools
🪛 actionlint (1.7.7)
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
20-20: the runner of "actions/cache@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
30-30: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🤖 Prompt for AI Agents
.github/workflows/ktlint_checker.yml around lines 17 to 33: the workflow uses
actions/checkout@v3, actions/cache@v3 and actions/setup-java@v3 which are
incompatible with the runner's Node 20 — update each referenced action to their
v4 releases (actions/checkout@v4, actions/cache@v4, actions/setup-java@v4) and
ensure any input names unchanged by the major bump are adjusted if necessary;
also mirror the same version updates in the pr_checker workflow to avoid similar
runtime failures.
Related issue 🛠
Work Description ✏️
Screenshot 📸
N/A
Uncompleted Tasks 😅
N/A
To Reviewers 📢
이제 좀 더 빨라지겠지...?
Summary by CodeRabbit