feat: OpenLDAP backend for user-info-fetcher #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #523
Decision about the CRD change has not been accepted yet.
One performance problem might be that
get_user_infocreates a new LDAP connection every time it's called. A connection pool might be a better solution but I did not want to overengineer it, especially since the AD backend does it the same way.I also only added support for authentication via bind credentials, as I don't think we support auth via Kerberos in other places were we connect to LDAP. We could think about adding support for this if it's needed, I skipped it for now.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker