Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Nov 13, 2025

Description

Fixes #523

Decision about the CRD change has not been accepted yet.

One performance problem might be that get_user_info creates a new LDAP connection every time it's called. A connection pool might be a better solution but I did not want to overengineer it, especially since the AD backend does it the same way.

I also only added support for authentication via bind credentials, as I don't think we support auth via Kerberos in other places were we connect to LDAP. We could think about adding support for this if it's needed, I skipped it for now.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti dervoeti changed the title feat: OpenLDAP backend feat: OpenLDAP backend for user-info-fetcher Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Openldap backend for user-info-fetcher

2 participants