Add builtin_list.

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

• Use builtin_list #9105
• Add builtin_list. #8856 👈 (View in Graphite)
• Merge input_builtin_vars and output_builtin_vars. #9382
• Hardcode builtin_ty_to_vm_name. #8855
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ilyalesokhin-starkware]

crates/cairo-lang-executable/src/compile_test_data/basic line 902 at r2 (raw file):

ret;
// footer
ret;

with standalone_mode = false.

Suggestion:

//! > standalone_mode
false

//! > cairo_code
#[executable]
#[inline(never)]
fn main() implicits(RangeCheck, Bitwise) {}

//! > result
// builtins: output, range_check, bitwise
// header
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
%{ WriteRunParam { dst: [ap + 0], index: 0 } %}
[ap + 2] = [fp + -5], ap++;
[ap + 2] = [fp + -5], ap++;
ap += 2;
call rel 9;
[ap + 0] = 0, ap++;
%{ AddMarker { start: memory[ap + -3], end: memory[ap + -2] } %}
[ap + -1] = [ap + -4];
[ap + 0] = [ap + -2], ap++;
[ap + 0] = [ap + -7], ap++;
[ap + 0] = [ap + -7], ap++;
ret;
// sierra based code
[fp + -5] = [ap + 0] + [fp + -6], ap++;
jmp rel 4 if [ap + -1] != 0;
jmp rel 11;
call rel 20;
[ap + 0] = [fp + -8], ap++;
[ap + 0] = [fp + -7], ap++;
[ap + 0] = 1, ap++;
[ap + 0] = [ap + -5], ap++;
[ap + 0] = [ap + -5], ap++;
ret;
ap += 4;
[ap + 0] = [fp + -8], ap++;
[ap + 0] = [fp + -7], ap++;
call rel 12;
[ap + 0] = 0, ap++;
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
ret;
[ap + 0] = 117999715903629884655797335944760714204113152088920212735095598, ap++;
call rel 6;
ret;
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
ret;
%{ memory[ap + 0] = segments.add() %}
ap += 1;
[fp + -3] = [[ap + -1] + 0];
[ap + 0] = [ap + -1], ap++;
[ap + 0] = [ap + -2] + 1, ap++;
ret;
// footer
ret;

[ilyalesokhin-starkware]

crates/cairo-lang-executable/src/compile_test_data/basic line 1010 at r2 (raw file):

ret;
// footer
ret;

with standalone_mode = false.

Suggestion:

//! > standalone_mode
false

//! > cairo_code
#[executable]
#[inline(never)]
fn main() implicits(RangeCheck, Bitwise, SegmentArena) {}

//! > result
// builtins: output, range_check, bitwise
// header
ap += 3;
%{ memory[ap + 0] = segments.add() %}
%{ memory[ap + 1] = segments.add() %}
[ap + 2] = 0, ap++;
[ap + 0] = [[ap + -1] + 0], ap++;
[ap + 0] = [[ap + -2] + 1], ap++;
[ap + -1] = [[ap + -3] + 2];
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
[ap + 0] = [ap + -5] + 3, ap++;
%{ WriteRunParam { dst: [ap + 0], index: 0 } %}
[ap + 2] = [fp + -5], ap++;
[ap + 2] = [fp + -5], ap++;
ap += 2;
call rel 36;
[ap + 0] = 0, ap++;
%{ AddMarker { start: memory[ap + -3], end: memory[ap + -2] } %}
[ap + -1] = [ap + -4];
[fp + 0] = [ap + -7];
[fp + 1] = [ap + -6];
[fp + 2] = [ap + -2];
[ap + 0] = [[ap + -5] + -2], ap++;
[ap + 0] = [[ap + -6] + -1], ap++;
[ap + -2] = [ap + -1];
jmp rel 4 if [ap + -2] != 0;
jmp rel 19;
[ap + 0] = [[ap + -7] + -3], ap++;
[ap + -3] = [ap + 0] + 1, ap++;
jmp rel 4 if [ap + -1] != 0;
jmp rel 12;
[ap + 0] = [[ap + -2] + 1], ap++;
[ap + 0] = [[ap + -3] + 3], ap++;
%{ memory.add_relocation_rule(src_ptr=memory[ap + -1], dest_ptr=memory[ap + -2] + 1) %}
[ap + -1] = [ap + -2] + 1;
[ap + 0] = [ap + -4] + 3, ap++;
[ap + -4] = [ap + 0] + 1, ap++;
jmp rel -12;
[ap + 0] = [fp + 2], ap++;
[ap + 0] = [fp + 0], ap++;
[ap + 0] = [fp + 1], ap++;
ret;
// sierra based code
[fp + -5] = [ap + 0] + [fp + -6], ap++;
jmp rel 4 if [ap + -1] != 0;
jmp rel 12;
call rel 23;
[ap + 0] = [fp + -9], ap++;
[ap + 0] = [fp + -8], ap++;
[ap + 0] = [fp + -7], ap++;
[ap + 0] = 1, ap++;
[ap + 0] = [ap + -6], ap++;
[ap + 0] = [ap + -6], ap++;
ret;
[ap + 0] = [fp + -9], ap++;
[ap + 0] = [fp + -7], ap++;
[ap + 0] = [fp + -8], ap++;
call rel 15;
[ap + 0] = [ap + -3], ap++;
[ap + 0] = [ap + -2], ap++;
[ap + 0] = [ap + -4], ap++;
[ap + 0] = 0, ap++;
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
ret;
[ap + 0] = 117999715903629884655797335944760714204113152088920212735095598, ap++;
call rel 7;
ret;
[ap + 0] = [fp + -5], ap++;
[ap + 0] = [fp + -4], ap++;
[ap + 0] = [fp + -3], ap++;
ret;
%{ memory[ap + 0] = segments.add() %}
ap += 1;
[fp + -3] = [[ap + -1] + 0];
[ap + 0] = [ap + -1], ap++;
[ap + 0] = [ap + -2] + 1, ap++;
ret;
// footer
ret;

[ilyalesokhin-starkware]

crates/cairo-lang-executable/src/compile_test_data/basic line 1010 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

with standalone_mode = false.

ignore, there was a here where local_exprs and output_builtin_vars got out of sync.

See r2 <-> r3

[ilyalesokhin-starkware]

crates/cairo-lang-executable/src/compile_test_data/basic line 902 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

with standalone_mode = false.

ignore, same a the comment bellow.

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 428 at r4 (raw file):

                casm_build_extend!(self.ctx, localvar local;);
                self.local_exprs.insert(BuiltinName::output, self.ctx.get_value(local, false));
            }

Why wasn't this needed before?

Code quote:

            if !self.config.testing {
                // Add a local variable for the output builtin
                casm_build_extend!(self.ctx, localvar local;);
                self.local_exprs.insert(BuiltinName::output, self.ctx.get_value(local, false));
            }

[ilyalesokhin-starkware]

@ilyalesokhin-starkware resolved 2 discussions.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion.

[ilyalesokhin-starkware]

crates/cairo-lang-runnable-utils/src/builder.rs line 428 at r4 (raw file):

Previously, ilyalesokhin-starkware wrote…

Why wasn't this needed before?

ok, it's because of the change above.

[orizi]

@orizi reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware).

---

crates/cairo-lang-runnable-utils/src/builder.rs line 583 at r5 (raw file):

        }

        for (name, var) in self.input_builtin_vars.iter() {

doc the loop.

[ilyalesokhin-starkware]

@ilyalesokhin-starkware made 1 comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi).

---

crates/cairo-lang-runnable-utils/src/builder.rs line 583 at r5 (raw file):

Previously, orizi wrote…

doc the loop.

done,
decided to merge self.input_builtin_vars and self.output_builtin_vars in the process.

[orizi]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware).

[orizi]

@orizi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware).

[orizi]

@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware).