Skip to content

Conversation

@DeVikingMark
Copy link
Contributor

Description

Adds brief explanations clarifying that type and impl aliases are not new types/impls.

Changes

  • Clarifies that type aliases are treated as the same type by the compiler and are interchangeable
  • Clarifies that impl aliases refer to the same implementation and can be used wherever the original impl is expected

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @DeVikingMark).


docs/reference/src/components/cairo/modules/language_constructs/pages/aliases.adoc line 3 at r1 (raw file):

= Type and impl aliases

A type alias is a new name for an existing type. It is not a new type. This means that the alias and the original type are treated as the same type by the compiler and can be used interchangeably. Type aliases are created with

limit line length to 100 chars.

@orizi
Copy link
Collaborator

orizi commented Dec 22, 2025

No response.

Closing.

@orizi orizi closed this Dec 22, 2025
@DeVikingMark
Copy link
Contributor Author

@orizi hi! but i've updated the line length why closing tho?

@orizi
Copy link
Collaborator

orizi commented Dec 22, 2025

maybe you updated locally - was not pushed here.

@DeVikingMark
Copy link
Contributor Author

Screenshot 2025-12-22 104236

@orizi hmm... it's strange, I've updated Pr with this commit, as you can see on the screenshot, but it doesn't display on your device. just curious what might be wrong?

@orizi orizi reopened this Dec 22, 2025
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DeVikingMark).

@orizi orizi enabled auto-merge December 22, 2025 09:10
@orizi
Copy link
Collaborator

orizi commented Dec 22, 2025

Not sure what happened - seeing now - reopened and approved.

@orizi orizi added this pull request to the merge queue Dec 22, 2025
Merged via the queue into starkware-libs:main with commit 2871f5f Dec 22, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants