Skip to content

Conversation

@isagi-y22
Copy link
Contributor

Enhances VersionError in program.rs to display both received and expected version numbers, making version mismatch issues immediately clear.

Before: Unsupported Sierra program version
After: Unsupported Sierra program version: got 2, expected 1

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @isagi-y22)


crates/cairo-lang-sierra/src/program.rs line 42 at r1 (raw file):

#[derive(Debug, Error)]
#[error("Unsupported Sierra program version: got {got}, expected {expected}")]
struct VersionError {

these are already clear enough - and the caller might not expect this change.
Close PR.

@orizi
Copy link
Collaborator

orizi commented Dec 22, 2025

No response.

Closing.

@orizi orizi closed this Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants