Skip to content

Conversation

@TomerStarkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TomerStarkware TomerStarkware requested a review from orizi December 21, 2025 15:23
@TomerStarkware TomerStarkware marked this pull request as ready for review December 21, 2025 15:23
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-semantic/src/items/functions.rs line 441 at r1 (raw file):

            }

            GenericFunctionWithBodyId::Trait(trt) => format!(

Suggestion:

            }
            GenericFunctionWithBodyId::Trait(trt) => format!(

@TomerStarkware TomerStarkware force-pushed the tomer/12-21-fixed_full_path_for_functions_in_a_generic_impl branch from 1ab74b0 to d73a1e6 Compare December 22, 2025 08:17
Copy link
Collaborator Author

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerStarkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi).


crates/cairo-lang-semantic/src/items/functions.rs line 441 at r1 (raw file):

            }

            GenericFunctionWithBodyId::Trait(trt) => format!(

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware).

@TomerStarkware TomerStarkware added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit c0118be Dec 22, 2025
54 checks passed
@orizi orizi deleted the tomer/12-21-fixed_full_path_for_functions_in_a_generic_impl branch December 22, 2025 15:52
Princetimix69 pushed a commit to Princetimix69/cairo that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants