apollo_gateway: document proof verification and storage in different places

[avivg-starkware]

places

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• apollo_gateway: document proof verification and storage in different places #11872 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[einat-starkware]

@einat-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).

---

crates/apollo_transaction_converter/src/transaction_converter.rs line 229 at r1 (raw file):

            RpcTransaction::Invoke(RpcInvokeTransaction::V3(tx)) => {
                // Verify proof here; storage happens in the gateway after validation to avoid
                // storing proofs for rejected transactions.

Do you think it's necessary to mention the validators? When converting from consensus to internal consensus they also call this function, but the storage happens in the outer function?

Code quote:

                // Verify proof here; storage happens in the gateway after validation to avoid
                // storing proofs for rejected transactions.

[avivg-starkware]

@avivg-starkware made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1).

---

crates/apollo_transaction_converter/src/transaction_converter.rs line 229 at r1 (raw file):

Previously, einat-starkware wrote…

Do you think it's necessary to mention the validators? When converting from consensus to internal consensus they also call this function, but the storage happens in the outer function?

yes!:) changed

[einat-starkware]

@einat-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

[noaov1]

@noaov1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).