Skip to content

Conversation

@meship-starkware
Copy link
Collaborator

number

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Artifacts upload workflows:

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@meship-starkware meship-starkware marked this pull request as ready for review January 21, 2026 14:11
Copy link
Contributor

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@avivg-starkware reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1).


crates/starknet_api/src/test_utils.rs line 228 at r1 (raw file):

/// Computes a deterministic block hash for testing purposes.
/// The hash is computed as `block_number * 100`.

optional

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @meship-starkware).


crates/starknet_api/src/test_utils.rs line 228 at r1 (raw file):

Previously, avivg-starkware wrote…

optional

+1


crates/blockifier/src/test_utils.rs line 434 at r1 (raw file):

/// Generates deterministic block hash storage updates for historical blocks.
/// Populates a range of blocks with deterministic hash values using `test_block_hash`.

Suggestion:

/// Populates a range of blocks with deterministic hash values.

@meship-starkware meship-starkware force-pushed the meship/add_util_for_test_block_hash branch from cde5122 to ce485e8 Compare January 25, 2026 07:10
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware resolved 2 discussions.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @avivg-starkware and @noaov1).

Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).

@meship-starkware meship-starkware added this pull request to the merge queue Jan 25, 2026
Merged via the queue into main with commit 0e637a7 Jan 25, 2026
24 checks passed
@meship-starkware meship-starkware deleted the meship/add_util_for_test_block_hash branch January 25, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants