-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_api: add a util that compute a test block hash from block number #11880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avivg-starkware reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1).
crates/starknet_api/src/test_utils.rs line 228 at r1 (raw file):
/// Computes a deterministic block hash for testing purposes. /// The hash is computed as `block_number * 100`.
optional
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @meship-starkware).
crates/starknet_api/src/test_utils.rs line 228 at r1 (raw file):
Previously, avivg-starkware wrote…
optional
+1
crates/blockifier/src/test_utils.rs line 434 at r1 (raw file):
/// Generates deterministic block hash storage updates for historical blocks. /// Populates a range of blocks with deterministic hash values using `test_block_hash`.
Suggestion:
/// Populates a range of blocks with deterministic hash values.cde5122 to
ce485e8
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware resolved 2 discussions.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @avivg-starkware and @noaov1).
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).

number