apollo_starknet_os_program: remove authorized accound address from vi… #11893
Conversation
Yoni-Starkware
requested review from
AvivYossef-starkware,
meship-starkware and
noaov1
|
This change is |
|
Artifacts upload workflows: |
Yoni-Starkware
force-pushed
the
yoni/apollo_starknet_os_program/rm-sender-address-virtual
branch
3 times, most recently
from
304025f to
c3ca799
Compare
Yoni-Starkware
force-pushed
the
yoni/apollo_starknet_os_program/rm-sender-address-virtual
branch
from
c3ca799 to
534e28e
Compare
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 16 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware).
crates/apollo_consensus_orchestrator/resources/central_invoke_tx_client_side_proving.json line 42 at r1 (raw file):
"0x2fa80", "0x1", "0x0"
Can you please remind me what that value represents?
Code quote:
"0x0"
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware).
crates/apollo_consensus_orchestrator/resources/central_invoke_tx_client_side_proving.json line 42 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Can you please remind me what that value represents?
What about the following json files:
crates/apollo_http_server/resources/deprecated_gateway/invoke_tx_client_side_proving.json
crates/apollo_starknet_client/resources/reader/invoke_v3_client_side_proving.json
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @Yoni-Starkware).
a discussion (no related file):
This need a matching python PR to not break the end to end test
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1).
a discussion (no related file):
Previously, meship-starkware (Meshi Peled) wrote…
This need a matching python PR to not break the end to end test
https://github.com/starkware-industries/starkware/pull/40035
crates/apollo_consensus_orchestrator/resources/central_invoke_tx_client_side_proving.json line 42 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
What about the following json files:
crates/apollo_http_server/resources/deprecated_gateway/invoke_tx_client_side_proving.json
crates/apollo_starknet_client/resources/reader/invoke_v3_client_side_proving.json
Done.
…rtual output