apollo_consensus_orchestrator,apollo_consensus: support real + virtual leader election

[asmaastarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• apollo_consensus_orchestrator,apollo_consensus: support real + virtual leader election #11900 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

This PR is way too big. For me, it's impossible to follow it through.
Suggestion:

1. Create a struct containing the existing LeaderFn and pass it everywhere instead of the current direct usage of the LeaderFn. (Refactor - no change in logic).
2. Add to the struct also the virtual_leader_fn (Refactor - no change in logic).
3. Specifically, use the virtual_leader_fn only in the place where deciding upon PreCommit count. Should be very minor and co-located.

@matanl-starkware made 4 comments.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @asmaastarkware and @dafnamatsry).

---

crates/apollo_consensus/src/single_height_consensus.rs line 107 at r1 (raw file):

            return VecDeque::new();
        }
        let proposer_id = virtual_leader_fn(block_info.round);

This should remain unchanged

Suggestion:

leader_fn

---

crates/apollo_consensus/src/manager.rs line 889 at r1 (raw file):

                    height,
                    round,
                    proposer: context.virtual_proposer(height, round),

The proposer should not change.
The virtual_proposer should only come into effect when counting PreCommit votes.

Code quote:

proposer: context.virtual_proposer(height, round),

---

crates/apollo_consensus/src/state_machine.rs line 534 at r1 (raw file):

                        height: self.height,
                        round: self.round,
                        proposer: virtual_leader_fn(self.round),

Keep as is

Code quote:

virtual_leader_fn(self.round),