-
Notifications
You must be signed in to change notification settings - Fork 91
feat(Keycard): Adding a keycard info drawer for Android to guide the keycard interactions #19549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix/keycard-nfc-3
Are you sure you want to change the base?
Conversation
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#1 🔹 ~19 min 🔹 23b6c55 🔹 📦 tests/ui package |
86711e0 to
e71a2fa
Compare
23b6c55 to
7515f6e
Compare
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#2 🔹 ~37 min 🔹 7515f6e 🔹 📦 tests/ui package |
✔️ status-desktop/e2e/prspr19549 🔹 ~17 min 🔹 7515f6e 🔹 📦 tests/e2e package |
e71a2fa to
adabada
Compare
7515f6e to
0561ebc
Compare
adabada to
cd46a72
Compare
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#4 🔹 ~32 min 🔹 240efa3 🔹 📦 tests/nim package |
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#4 🔹 ~38 min 🔹 240efa3 🔹 📦 tests/ui package |
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#5 🔹 ~44 min 🔹 b1b5809 🔹 📦 tests/nim package |
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#5 🔹 ~50 min 🔹 b1b5809 🔹 📦 tests/ui package |
|
Hi @alexjba , tried on Moto G55, Android 14. During onboarding flow (create with empty keycard) it consistently ends up on "Smartcard reader service unavailable" after "reading card" is shown in the drawer. In the logs I can see it go from tag discovered view logcat (message:nfc) and screenshot
|
caybro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work but some suggestions
bcf9a24 to
aab486b
Compare
aab486b to
668b750
Compare
b1b5809 to
1daf137
Compare
Jenkins BuildsClick to see older builds (62)
|
668b750 to
e2f0b36
Compare
1daf137 to
0206c96
Compare
e2f0b36 to
98d9bc1
Compare
…keycard interactions Adding a `KeycardChannelDrawer` that's guiding the user whenever the keycard is needed. On IOS the system drawer is used
…ponents - use a single KeycardStateDisplay instance with the necessary states - The state queue, transitions and entire logic moved to KeycardChannelStateManager component
The constants are moved from nim to qml
- Adding states for HW adaptor states - Implement `Dismiss` action
…ing blocked This commit updates parts of the login flows. Adds a new `Scan keycard` button to trigger keycard detection on demand. + Update keycard states in the login flow + Show digits only on soft keyboard for pin input
272901d to
48b2d5c
Compare
caybro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, just some final questions
| maximumLength: root.pinLen | ||
| validator: d.statusValidator.validatorObj | ||
| inputMethodHints: root.inputMethodHints | ||
| // validator: d.statusValidator.validatorObj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validator disabled on purpose?
|
|
||
|
|
||
| Loader { | ||
| active: SQUtils.Utils.isAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android only on purpose?





What does the PR do
Iterating
#19545
#19546
#19547
#19548
Adding a
KeycardChannelDrawerthat's guiding the user whenever the keycard is needed.On IOS the system drawer is used.
Screencapture of the functionality
Screen_Recording_20251210_154214_Status.mp4
ScreenRecording_12-10-2025.17-21-13_1.MP4
Screen.Recording.2025-12-10.at.15.11.49.mov
Impact on end user
How to test
desktop:
make run USE_STATUS_KEYCARD_QT=1iOS:
make mobile-run USE_STATUS_KEYCARD_QT=1 DEVELOPMENT_TEAM=...android:
make mobile-run