Storybook: generic, unified theme handling #19596
Open
+352
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moreover: - Storybook own font size pinpointed to fixed value - Storybook dark/light mode only for SB's own use, not affecting app theme
Member
Jenkins BuildsClick to see older builds (11)
|
caybro
reviewed
Dec 16, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Nice work overall, just some minor things here and there
| text: modelData | ||
|
|
||
| onClicked: root.paddingFactorRequested( | ||
| ThemeUtils["Padding" + modelData]) |
Member
There was a problem hiding this comment.
Oh, does that work? 🤯 (converting a string to enum value)
Member
Author
There was a problem hiding this comment.
Just js. If sth can be accessed as ThemeUtils.PaddingXL it can be accessed as ThemeUtils["PaddingXL"] as well 😁
Member
There was a problem hiding this comment.
Ha... right... reminds me of the famous C array surprise 😆
int p[3] = {1, 2, 3};
assert(p[1] == 1[p]); // OK; exactly the same
caybro
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
This PR adds controls to manipulate theme on every Storybook page in separation. The settings are persisted per page. Can be also reset to default values.
Moreover:
Affected areas
StorybookArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screencast.from.16.12.2025.13.16.30.webm