feat: refetch transaction history button #19601
Conversation
dlipicar
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds a "Refetch transaction history" button in the Advanced settings section to help users manually trigger a re-fetch of their transaction history when experiencing issues with missing transactions.
Key changes:
- Added a new UI control in Advanced settings with a "Refetch" button that changes to "Done" after being clicked
- Updated the beta warning message to direct users to the new refetch functionality instead of external block explorers
- Implemented the backend RPC call chain through the wallet service to trigger transaction history refetch
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/status-go | Updated subproject commit reference |
| ui/imports/shared/views/HistoryBetaTag.qml | Simplified beta tag message and removed explorer link generation logic |
| ui/i18n/*.ts | Added translation strings for "Refetch transaction history", "Refetch", and "Done" across multiple locales |
| ui/app/AppLayouts/Profile/views/AdvancedView.qml | Added new UI section with refetch button and completion state tracking |
| ui/app/AppLayouts/Profile/stores/AdvancedStore.qml | Added refetchTxHistory function that calls wallet module |
| src/backend/wallet.nim | Added RPC call definition for refetchTxHistory |
| src/app_service/service/wallet_account/service.nim | Implemented service method to call backend refetchTxHistory |
| src/app/modules/main/profile_section/wallet/*.nim | Added refetchTxHistory methods through view, module, interface, and controller layers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| property bool refetchTxHistoryCompleted: false | ||
| onVisibleChanged: { | ||
| root.refetchTxHistoryCompleted = false | ||
| } |
There was a problem hiding this comment.
The refetchTxHistoryCompleted state is reset every time the view becomes visible, but this approach doesn't account for the view becoming hidden. Consider resetting the state when visibility changes to false specifically, or add a comment explaining why resetting on any visibility change is the desired behavior.
|
|
||
| spacing: Theme.padding | ||
|
|
||
| height: 64 |
There was a problem hiding this comment.
The height is hardcoded to 64. Consider using a Theme constant or calculating the height based on content to maintain consistency with other UI elements and support different display scales.
| } | ||
|
|
||
| function refetchTxHistory() { | ||
| if(!root.walletModule) |
There was a problem hiding this comment.
Missing space after 'if' keyword. The spacing should be 'if (!root.walletModule)' to follow QML/JavaScript style conventions.
| rpc(refetchTxHistory, "wallet"): | ||
| discard |
There was a problem hiding this comment.
The RPC procedure lacks documentation explaining its purpose and expected behavior. Add a docstring describing what refetchTxHistory does and any side effects or requirements.
Jenkins BuildsClick to see older builds (10)
|
| property bool refetchTxHistoryCompleted: false | ||
| onVisibleChanged: { | ||
| root.refetchTxHistoryCompleted = false | ||
| } |
4 participants
What does the PR do
Cherrypicks #19544
status-go part status-im/status-go#7220
Closes #19542