bench: refactor to use string interpolation in number/uint32/base/mul
#8944
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors JavaScript benchmarks in
number/uint32/base/mul to use string interpolation via
@stdlib/string/format instead of string concatenation when
specifying benchmark names. This improves readability,
facilitates easier debugging of malformed benchmark names, and
enables future linting of benchmark names.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Good First PR
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses a part of #8647.
Description
This pull request:
number/uint32/base/multo use string interpolation via@stdlib/string/formatinstead of string concatenation when specifying benchmark names@stdlib/string/formatimport to two benchmark files:benchmark.jsandbenchmark.native.jspkg+'::inline',pkg+'::native') with format function calls using appropriate format specifiersRelated Issues
This pull request has the following related issues:
Questions
No.
Other
All benchmarks were tested locally using:
make benchmark BENCHMARKS_FILTER=".*/number/uint32/base/mul/.*"Checklist
AI Assistance
@stdlib-js/reviewers