Refactor object #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectState is an empty interface and never used other than being extended by AtomicObjectState. RdObject currently is tied to Atomic implementation and I will probably stay that way
trying to separate this work from next commit
Now the object id's are autogenerated on new rdo's and are kept track in the state of the rdo
giannislelekas
requested review from
Iptonius,
PhilipeLouchtch and
steffansluis
Collaborator
|
This refactoring doesn't make sense to me. It certainly is not how I intended to interaction of pushing/fetching objects (states of) to be. Could you please first clearly introduce and motivate the design/approach? |
Collaborator
Author
Is there any particular reason you need this as a method of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored objectID; moved functionality to server side. Every new AtomicState at server side is assigned a static objectId, which is then used as a key to map to the state. The state along with the corresponding id is transferred back and forth between client-server. The id does not change even after an update of a state.