Update assertion to expect null on an undefined option #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
leighmcculloch
approved these changes
Oct 30, 2025
elizabethengelman
force-pushed
the
update-ts-bindings-test
branch
from
2f9f48a to
162cdee
Compare
elizabethengelman
force-pushed
the
update-ts-bindings-test
branch
from
162cdee to
beb6dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a failing test where the option fn was returning
nullinstead of the expectedundefined. This PR just changes it to expectnullinstead.The change passes locally, though I’d appreciate a sanity check to confirm this is the right approach.
I also made a few clippy-related changes to use
cloneoverto_stringfor Strings.