Skip to content

Conversation

@anish-mudaraddi
Copy link
Collaborator

pull korc envvar from dependencies

meoflynn
meoflynn previously approved these changes Jan 27, 2026
@DavidFair
Copy link
Collaborator

Shell check is flagging a valid warning here, if the name is missing (usually human error) we'll carry on using junk in the var

Could we pre-set these vars to NOT_SET before reading using jq, this also acts as a guard because if a user contacts us it's easy to see the NOT_SET and ask if they've changed their dependencies file

@DavidFair
Copy link
Collaborator

DavidFair commented Jan 27, 2026

I think this will break as we're now setting them to NOT_SET overriding the original values read in line 28, unless I'm reading it wrong?

I think the NOT_SET needs to be before set_env_vars "dependencies.json", so if any are missing in from dependencies.json it will stay as NOT_SET

Copy link
Collaborator

@DavidFair DavidFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested on a VM, this is still working the the additional changes so LGTM

./bootstrap.sh 
Set ADDON_PROVIDER=0.10.3
Set AZIMUTH_IMAGES=0.24.0
Set CLUSTER_API=v1.12.1
Set CLUSTER_API_JANITOR_OPENSTACK=0.10.5
Set CLUSTER_API_PROVIDER_OPENSTACK=v0.13.2
Set CERT_MANAGER=v1.19.2
Set HELM=v3.17.3
Set SONOBUOY=v0.57.3
Set CLUSTER_CHART=0.19.0

@meoflynn meoflynn merged commit 09584e2 into stfc:master Jan 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants