Docker image for username service #131
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmatthews20
force-pushed
the
stfc-username-service
branch
23 times, most recently
from
fb18f96 to
f45d149
Compare
Docker image for the username service used to generate fedid accounts on VMs
Add golangci-lint job to ci pipeline for username service docker image
gmatthews20
force-pushed
the
stfc-username-service
branch
from
f45d149 to
9e874cd
Compare
anish-mudaraddi
previously approved these changes
Nov 25, 2025
Stop using init() not recommended method to set up connections also made it difficult to add tests. Use client struct instead. Add user handler to a service struct so the function can use the client
Add success and failure tests for getting user details from openstack for the username service
gmatthews20
force-pushed
the
stfc-username-service
branch
4 times, most recently
from
e9464e2 to
2ccb128
Compare
Add a stage to run go tests in the docker image build process. This was following steps from docker docs here: https://docs.docker.com/guides/golang/run-tests/
Rename stage names to conform to linting requirments
Add additional job to the github workflow for the username service which runs the tests inside the conainer, make build and push stages depend on the test and lint jobs
Add error checks in the go tests
gmatthews20
force-pushed
the
stfc-username-service
branch
from
d6d801a to
f34937d
Compare
anish-mudaraddi
approved these changes
Dec 16, 2025
meoflynn
requested changes
Jan 23, 2026
Contributor
There was a problem hiding this comment.
Could you add docstrings to the functions?
| return userDetails.Name, nil | ||
| } | ||
|
|
||
| func main() { |
Contributor
There was a problem hiding this comment.
Could you add a docstring for this method?
| } | ||
| } | ||
|
|
||
| func (s service) getUserHandler(w http.ResponseWriter, r *http.Request) { |
Contributor
There was a problem hiding this comment.
Could you add a docstring for this function?
Contributor
There was a problem hiding this comment.
Could you add docstrings to the unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image for the username service used to generate fedid accounts on VMs